Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Add tests for reduce reconcilement predicate methods (PR 1359) #1373

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

yrs147
Copy link
Contributor

@yrs147 yrs147 commented Jul 2, 2024

What this PR does / why we need it:
Add tests for #1359
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1360

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@yrs147 yrs147 changed the title 🌱Add tests for PR 1359 🌱(WIP)Add tests for PR 1359 Jul 2, 2024
@yrs147 yrs147 requested a review from janiskemper July 3, 2024 06:58
@yrs147 yrs147 changed the title 🌱(WIP)Add tests for PR 1359 🌱Add tests for PR 1359 Jul 8, 2024
@yrs147 yrs147 marked this pull request as ready for review July 9, 2024 12:19
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Jul 9, 2024
@yrs147 yrs147 changed the title 🌱Add tests for PR 1359 🌱Add tests for reduce reconcilement predicate methods (PR 1359) Jul 9, 2024
@yrs147 yrs147 merged commit abdc74f into main Jul 9, 2024
19 checks passed
@yrs147 yrs147 deleted the yrs/tests-1359 branch July 9, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for PR #1359
2 participants